Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): add Cryostat event template and fix CryostatTemplateIT #27

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

maxcao13
Copy link
Member

Related #2

@maxcao13 maxcao13 added the feat New feature or request label Jun 22, 2023
@maxcao13 maxcao13 requested a review from andrewazores June 22, 2023 01:16
@maxcao13
Copy link
Member Author

Interestingly, I can only request up to 1 reviewer.

And unrelated, I'm a bit unfamiliar with the build process, but for some reason for me the Cryostat template does not show up when running quarkus dev but does so on smoketest. I run quarkus build before hand, but do I have to run something else before hand?

@andrewazores
Copy link
Member

Interestingly, I can only request up to 1 reviewer.

I'm not sure but this is probably a restriction due to this being a private repository. We don't have branch protection rules either, and cannot create draft PRs, until we either pay for an organization pro account or make the repo public.

And unrelated, I'm a bit unfamiliar with the build process, but for some reason for me the Cryostat template does not show up when running quarkus dev but does so on smoketest. I run quarkus build before hand, but do I have to run something else before hand?

quarkus dev works like the devserver.sh in the old repo, ie it runs the server as a plain process directly on your host machine, without doing a container build. Even if you do quarkus build first, this will just build a container image and then run a direct host process after, so the template file will not be picked up by that process.

@maxcao13
Copy link
Member Author

Ah ok, that makes sense, thanks.

@andrewazores andrewazores merged commit bdb402e into cryostatio:main Jun 22, 2023
@maxcao13 maxcao13 deleted the CryostatTemplateIT branch June 22, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants