Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(startup): enable startup profiling recording #254

Merged

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #28

Description of the change:

Adds a startup profiling flight recording to Cryostat itself in smoketesting.

Motivation for the change:

We can/should use this recording every now and then to check Cryostat's own startup performance and look for ways to optimize it so that the startup is faster and leaner.

How to manually test:

  1. ./smoketest.bash
  2. Open web UI on http://localhost:8080
  3. Select localhost:0 target, go to Recordings > Active Recordings and verify that the startup recording is present

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Jan 22, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 1/22/2024, 11:07:45 AM. View Actions Run.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7613996519

1 similar comment
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7613996519

@andrewazores andrewazores merged commit 9165dac into cryostatio:main Jan 22, 2024
12 of 13 checks passed
@andrewazores andrewazores deleted the startup-profiling-recording branch January 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants