Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): swap seaweedfs upstream image for cryostat-storage #241

Merged
merged 6 commits into from
Jan 23, 2024
Merged

test(storage): swap seaweedfs upstream image for cryostat-storage #241

merged 6 commits into from
Jan 23, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Depends on cryostatio/cryostat-storage#1

@andrewazores andrewazores added test chore Refactor, rename, cleanup, etc. labels Jan 15, 2024
@github-actions github-actions bot added dependent needs-triage Needs thorough attention from code reviewers labels Jan 15, 2024
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Jan 17, 2024
@andrewazores andrewazores mentioned this pull request Jan 17, 2024
Merged
@andrewazores andrewazores force-pushed the storage-container branch 3 times, most recently from 0a818aa to 1259744 Compare January 22, 2024 14:20
@andrewazores andrewazores marked this pull request as ready for review January 22, 2024 21:06
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 1/22/2024, 4:34:22 PM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7617633627

1 similar comment
@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7617633627

aali309
aali309 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 1/22/2024, 10:25:02 PM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7620627649

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7620627649

@andrewazores andrewazores merged commit 71ab032 into cryostatio:main Jan 23, 2024
8 checks passed
@andrewazores andrewazores deleted the storage-container branch January 23, 2024 03:43
@andrewazores andrewazores mentioned this pull request Jan 24, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @aali309