Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump io.cryostat:cryostat-core from 2.24.0 to 2.25.0 #201

Merged
merged 2 commits into from
Dec 5, 2023
Merged

build(deps): bump io.cryostat:cryostat-core from 2.24.0 to 2.25.0 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a3495
build(deps): bump io.cryostat:cryostat-core from 2.24.0 to 2.25.0
dependabot[bot] Dec 5, 2023
d4f2461
hack patch to fix compilation
andrewazores Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<io.cryostat.core.version>2.24.0</io.cryostat.core.version>
<io.cryostat.core.version>2.25.0</io.cryostat.core.version>

<org.apache.commons.codec.version>1.16.0</org.apache.commons.codec.version>
<org.apache.commons.io.version>2.13.0</org.apache.commons.io.version>
Expand Down
11 changes: 11 additions & 0 deletions src/main/java/io/cryostat/targets/AgentConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.openjdk.jmc.rjmx.ServiceNotAvailableException;

import io.cryostat.core.FlightRecorderException;
import io.cryostat.core.JvmIdentifier;
import io.cryostat.core.net.CryostatFlightRecorderService;
import io.cryostat.core.net.IDException;
import io.cryostat.core.net.JFRConnection;
Expand Down Expand Up @@ -101,6 +102,16 @@ public String getJvmId() throws IDException, IOException {
return Target.getTargetByConnectUrl(agentUri).jvmId;
}

@Override
public JvmIdentifier getJvmIdentifier() throws IDException, IOException {
// try {
// return JvmIdentifier.from(getMBeanMetrics().getRuntime());
// } catch (IntrospectionException | InstanceNotFoundException | ReflectionException e) {
// throw new IDException(e);
// }
throw new UnsupportedOperationException("Unimplemented method 'getJvmIdentifier'");
}

@Override
public int getPort() {
return agentUri.getPort();
Expand Down
Loading