Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spotbugs): resolve spotbugs warnings #120

Merged
merged 9 commits into from
Oct 25, 2023
Merged

chore(spotbugs): resolve spotbugs warnings #120

merged 9 commits into from
Oct 25, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #113

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Oct 24, 2023
@andrewazores
Copy link
Member Author

@aali309 @mwangggg ping - I'd like to get this merged so the CI can start passing :-)

mwangggg
mwangggg approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewazores andrewazores merged commit 6e2af66 into cryostatio:main Oct 25, 2023
8 checks passed
@andrewazores andrewazores deleted the spotbugs-cleanup branch October 25, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwangggg mwangggg mwangggg approved these changes

@aali309 aali309 aali309 approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Clean up Spotbugs deficiencies or suppress
3 participants
@andrewazores @aali309 @mwangggg