Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): updated to take compare fork image sample #114

Merged
merged 2 commits into from
Oct 20, 2023
Merged

feat(ci): updated to take compare fork image sample #114

merged 2 commits into from
Oct 20, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Oct 20, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related: #112

Description of the change:

This is to add the missing images on CONTRIBUTING.md file

Motivation for the change:

To give the contributor a clear image sample guide of the pages they will navigate

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Oct 20, 2023
@aali309 aali309 added ci safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Oct 20, 2023
@aali309 aali309 marked this pull request as ready for review October 20, 2023 14:11
@aali309
Copy link
Contributor Author

aali309 commented Oct 20, 2023

/request_review

@aali309
Copy link
Contributor Author

aali309 commented Oct 20, 2023

/request_review

@andrewazores andrewazores merged commit b82bb7e into cryostatio:main Oct 20, 2023
7 of 8 checks passed
@aali309 aali309 deleted the addMissingImages branch October 20, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
ci review-requested safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aali309 @andrewazores