Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(itest): enable jfr-datasource recording upload test #140

Merged
merged 32 commits into from
Nov 7, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 3, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #42

Description of the change:

Re-enables the UploadRecordingIT with some modifications.

@andrewazores andrewazores added test chore Refactor, rename, cleanup, etc. labels Nov 3, 2023
@andrewazores andrewazores requested a review from lkonno November 3, 2023 16:08
Copy link

github-actions bot commented Nov 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
Copy link

github-actions bot commented Nov 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

github-actions bot commented Nov 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

github-actions bot commented Nov 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

github-actions bot commented Nov 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@lkonno
Copy link
Contributor

lkonno commented Nov 6, 2023

@andrewazores I think that you can keep UploadRecordingTest disabled, I will fix it after this update.

@andrewazores andrewazores marked this pull request as ready for review November 6, 2023 19:16
@andrewazores andrewazores marked this pull request as draft November 6, 2023 20:45
@andrewazores
Copy link
Member Author

integration tests seem to work fine locally but are consistently failing in CI. I'll look into why and ping you again for review @lkonno when I figure it out.

@andrewazores andrewazores marked this pull request as ready for review November 7, 2023 15:06
@andrewazores
Copy link
Member Author

@lkonno the RulesPostJsonIT was already a little flakey before but somehow it seems to have become flakier with the changes to the StandardSelfTest base. I'll try to investigate that separately later on.

Copy link
Contributor

@lkonno lkonno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewazores
Copy link
Member Author

@lkonno I think this is properly cleaned up now.

@andrewazores andrewazores merged commit 3d30433 into cryostatio:main Nov 7, 2023
11 checks passed
@andrewazores andrewazores deleted the itest-fixups branch November 7, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants