Skip to content

Commit

Permalink
chore(discovery): rename discovery config properties (#31)
Browse files Browse the repository at this point in the history
  • Loading branch information
mwangggg authored Jun 27, 2023
1 parent 187b3be commit 0984f35
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
</execution>
</executions>
<configuration>
<jvmArgs>-Dcryostat.jdp.enabled=true -Dcryostat.podman.enabled=true -XX:+FlightRecorder -XX:StartFlightRecording=name=onstart,settings=default,disk=true,maxage=5m -Dcom.sun.management.jmxremote.autodiscovery=true -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=9091 -Dcom.sun.management.jmxremote.rmi.port=9091 -Djava.rmi.server.hostname=127.0.0.1 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.local.only=false</jvmArgs>
<jvmArgs>-Dcryostat.discovery.jdp.enabled=true -Dcryostat.discovery.podman.enabled=true -XX:+FlightRecorder -XX:StartFlightRecording=name=onstart,settings=default,disk=true,maxage=5m -Dcom.sun.management.jmxremote.autodiscovery=true -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=9091 -Dcom.sun.management.jmxremote.rmi.port=9091 -Djava.rmi.server.hostname=127.0.0.1 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.local.only=false</jvmArgs>
</configuration>
</plugin>
<plugin>
Expand Down
4 changes: 2 additions & 2 deletions smoketest/compose/cryostat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ services:
io.cryostat.jmxPort: "0"
io.cryostat.jmxUrl: "service:jmx:rmi:///jndi/rmi://localhost:0/jmxrmi"
environment:
CRYOSTAT_PODMAN_ENABLED: "true"
CRYOSTAT_JDP_ENABLED: "true"
CRYOSTAT_DISCOVERY_PODMAN_ENABLED: "true"
CRYOSTAT_DISCOVERY_JDP_ENABLED: "true"
JAVA_OPTS_APPEND: "-XX:+FlightRecorder -XX:StartFlightRecording=name=onstart,settings=default,disk=true,maxage=5m -Dcom.sun.management.jmxremote.autodiscovery=true -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=9091 -Dcom.sun.management.jmxremote.rmi.port=9091 -Djava.rmi.server.hostname=127.0.0.1 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.local.only=false"
restart: unless-stopped
healthcheck:
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/cryostat/discovery/JDPDiscovery.java
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ static JvmDiscoveryClient produceJvmDiscoveryClient() {
@Inject JvmDiscoveryClient jdp;
@Inject Vertx vertx;

@ConfigProperty(name = "cryostat.jdp.enabled")
@ConfigProperty(name = "cryostat.discovery.jdp.enabled")
boolean enabled;

@Transactional
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/cryostat/discovery/PodmanDiscovery.java
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public class PodmanDiscovery {
@Inject JFRConnectionToolkit connectionToolkit;
@Inject ObjectMapper mapper;

@ConfigProperty(name = "cryostat.podman.enabled")
@ConfigProperty(name = "cryostat.discovery.podman.enabled")
boolean enabled;

@Transactional
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/application-dev.properties
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ quarkus.http.cors.exposed-headers=X-JMX-Authorization,X-JMX-Authenticate,X-WWW-A
quarkus.hibernate-orm.database.generation=drop-and-create
quarkus.hibernate-orm.log.sql=true

cryostat.jdp.enabled=true
cryostat.podman.enabled=true
cryostat.discovery.jdp.enabled=true
cryostat.discovery.podman.enabled=true
4 changes: 2 additions & 2 deletions src/main/resources/application-test.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
quarkus.smallrye-openapi.info-title=Cryostat API (test)

cryostat.jdp.enabled=true
cryostat.podman.enabled=true
cryostat.discovery.jdp.enabled=true
cryostat.discovery.podman.enabled=true
cryostat.auth.disabled=true
4 changes: 2 additions & 2 deletions src/main/resources/application.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
quarkus.naming.enable-jndi=true
cryostat.jdp.enabled=false
cryostat.podman.enabled=false
cryostat.discovery.jdp.enabled=false
cryostat.discovery.podman.enabled=false

quarkus.test.integration-test-profile=test

Expand Down

0 comments on commit 0984f35

Please sign in to comment.