-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quickstarts/tour): add Cryostat guided tour and various QuickStarts #910
feat(quickstarts/tour): add Cryostat guided tour and various QuickStarts #910
Conversation
0c3eba9
to
ebcac8b
Compare
Test image available:
|
ebcac8b
to
605940b
Compare
Should be ready for light review, settings quickstart could use extra work, and dashboard quick start has been started yet. |
Test image available:
|
Awesome. The tour currently misses Automated Rules and Events nav items, I think those should be covered too. Events should be pretty brief to summarize, and Automated Rules doesn't need too much explanation here since there is also a quickstart for it that explains it in depth (also nice). |
Looks amazing! I am blown away :D Just a notice that some references to an element is not working (maybe the element is lacking the |
Test image available:
|
Test image available:
|
Test image available:
|
I think this should be pluralized: "allow you to start recordings on target JVMs based on sets of conditions" Any particular reason for calling out reports here? Reports can also be generated on the Recordings and Dashboards views, after all.
"The Events page lists the Event Templates that can be used for creating Flight Recordings. It also details the JFR Event Types that can be recorded within each target JVM." |
Test image available:
|
Test image available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementations and contents look good to me! Leaving to Andrew for finalizing contents :))
One last little nitpick: please remove mentions of the word "upstream", and wherever this is referring to some URL, please ensure that URL is provided by the |
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
a8ea514
to
407aa17
Compare
Test image available:
|
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Test image available:
|
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #902
Closes: #880
Description of the change:
Adds a guided tour to Cryostat, similar to what Openshift does and adds 4? new quickstarts. These quickstarts and guide can be found under the (?) help button.
How to manually test:
Run normally and try each of these components out.