-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): implement embedded chart cards #856
Merged
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
65fdfe4
feat(dashboard): add basic embedded chart cards
andrewazores 2aa79ba
refactor iframe src construction
andrewazores 4a1344c
add logical controller for all grafana chart cards
andrewazores 8333656
release subscriptions when no controller subscribers
andrewazores 9df6353
cleanup
andrewazores 30ae0a4
replace px count with em
andrewazores bc91498
wrap content in CardBody
andrewazores fe4fe01
slow refresh rate
andrewazores 1b7f63f
add refresh and popout buttons, style plainly
andrewazores 61f0c6c
add TODO
andrewazores c29f50e
refactor, simplify controller timing
andrewazores dee7e6a
cleanup controller instantiation and resource handling. button handli…
andrewazores e884006
use embedded grafana builtin refresh capability
andrewazores 2657517
cleanup, fix bug with no-recording target selection
andrewazores 04c21a7
fixup! cleanup, fix bug with no-recording target selection
andrewazores adb7194
add leniency for loading no-longer-known card types from storage
andrewazores fb8a214
refactor cleanup
andrewazores 02e8bb3
reset iframe on target change to force data refresh
andrewazores 35d05c2
add TODO
andrewazores d3df2b6
update empty state
andrewazores 393884f
re-add a refresh button to reset chart card
andrewazores 48d7c11
only apply negative margin on wider cards
andrewazores d94ba0a
cleanup
andrewazores 9f07067
react to recording start/stop/delete
andrewazores cb382ff
require recording to be running
andrewazores 9941032
extract min refresh to settings
andrewazores 9fdcf72
break circular dep
andrewazores b3827f4
add checkbox for restarting existing recordings
andrewazores 256cec8
add basic snapshot test
andrewazores 1b14d6f
fix settings test
andrewazores da14d3e
add more tests
andrewazores d5967d7
fix imports
andrewazores 6ea3b2f
rebase fixup
andrewazores f752ef1
use consistent card height
andrewazores 5bdb9ce
fix array key warnings
andrewazores 092243f
add missing set state call
andrewazores 5830893
use function form set state
andrewazores 2d0da2c
remove redundant nullsafe nav check
andrewazores b64a84f
use array destructuring
andrewazores b231f90
remove redundant first operator
andrewazores 53989ca
remove more redundant nullsafe navs
andrewazores 7bc14f3
replace <code> with <Label>
andrewazores e095b67
set description empty to remove redundant explanation
andrewazores 020ecc2
rename button
andrewazores 8adb794
memoize controller context
andrewazores b16b7a4
reduce negative margin for easier dragging and resizing
andrewazores 0c7bc07
allow dynamic card height
andrewazores eb72df8
localize card content
andrewazores 9727fd8
correct tests for localization
andrewazores 8ad0f06
add typedefs for react-test-renderer
andrewazores 6d5f0eb
remove redundant fragment wrapping
andrewazores 3e58e6f
tmp? loading view
andrewazores d16c65a
refactor cleanup/simplify, also fixes tests
andrewazores 1664e2a
add snapshot for loading state
andrewazores 5ea6508
controller initialization bugfix
andrewazores 137e619
use Continuous template instead, seems to generally support most metr…
andrewazores 8925f57
reset history and perform cleanup between tests
andrewazores 64fb8eb
set provider order to match real application
andrewazores 1ed7d69
experiment with generic provider render function
andrewazores dc1842e
move generic function into Common, expect localized view in test
andrewazores aae97f6
temporarily disable pointer events on iframes while resizing
andrewazores a7c86a5
apply pointer events disabling during drag-and-drop
andrewazores 63a5ca2
downgrade to BETA
andrewazores 2cc6b03
lint fix
andrewazores File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice these aria-labels have a different scheme from some other aria labels in the file
e.g.
Maybe either change this or we should change the other ones to keep consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to document key format somewhere too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean just change the way that the key is split up? Or change the actual localized text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the way the key is split up. Maybe we should have
in the same format in this PR that you have done here. If so, then that's okay to change in a separate refactor PR.
Just keeping a consistent key format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I don't really mind either way. I think there probably are/will be instances where the
aria-label
matches some text that is visually rendered, so specifyingARIA_LABELS
as part of the key maybe doesn't make the most sense.