fix(notifications): handle overflow #761
Conversation
|
Test image available: |
|
Test image available: |
andrewazores
force-pushed
the
notification-overflow
branch
from
1dd3122 to
191bcf0
Compare
|
Test image available: |
andrewazores
force-pushed
the
notification-overflow
branch
from
191bcf0 to
a2cfa19
Compare
|
Test image available: |
|
Test image available: |
|
Test image available: |
andrewazores
force-pushed
the
notification-overflow
branch
from
3006115 to
18859f6
Compare
|
Test image available: |
|
Test image available: |
|
Just a small detail: If I have the drawer open, and notifications come in. I see them in the list and the top-right pop-ups are hidden.
If I close the notification drawer, the pop-ups appear:
Do you think if any un-read notifications that appear while the drawer is open should be hidden by timing-out early? Not sure if we can do anything about that. |
|
Hmm. Not sure it's worth bothering to handle. I guess it could be done by checking if the drawer is open when new notifications are added and setting the |
|
Test image available: |
Yeh agreed. Do you think this PR can include these changes? |
|
Sure, I'll look at it now. |
|
Test image available: |
|
Test image available: |
… notifications default hidden
andrewazores
force-pushed
the
notification-overflow
branch
from
b3390ed to
0e4ad8a
Compare
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Seems like ci failed the first time with the exact test failure: https://github.com/cryostatio/cryostat-web/actions/runs/3734294205/jobs/6336169378 as described in #661 (comment). Cant reproduce it very consistently tho, but seems to occur more frequently lately. |
|
Test image available: |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #757
Description of the change:
This change adds overflow handling to the notification alert group and notification drawer.
https://www.patternfly.org/v4/components/alert-group#toast-alert-group-with-overflow-capture
Motivation for the change:
This reduces visual clutter on the screen and keeps the UI from feeling overfilled and chaotic when many actions are happening within a short timeframe. It is also easier for the user to dismiss all notifications when there are very many since the notification drawer can be summoned in a second way (clicking the overflow message), and summoning the drawer also hides the toast boxes.
How to manually test:
There is a new temporary plus button on the top bar to help testing. This is to be removed before merge. Clicking it adds a new notification immediately.
Generate notifications with the temporary button or by any other means and observe the Overflow message that appears when there are too many notifications. Go to the Settings view and try changing the visible notifications count to various values and repeat.