-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(targets): target select component can be expanded to reveal details #501
Conversation
b731bc1
to
c8c258b
Compare
922edd8
to
48e52ca
Compare
48e52ca
to
86db4c5
Compare
f93a0c8
to
fe3608f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Feel very nice! Just a couple of questions :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, just a general question for the future and not content for this PR.
When we start to populate the Dashboard with various things listed in the Epic here https://github.com/cryostatio/cryostat/issues/945, does it make sense that SerializedTargets
will start to include some data around things like CPU, memory, network, most recent archived recordings, Automated Analysis reports, etc. ? Or maybe have another wrapper around the SerializedTarget
which includes that extra info, and keeps the Targets modular as they are?
I don't think that info would go inside the |
a1ac398
to
f261836
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Very nicee :D
Related to #429
Related to #468