Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(credentials): clean up UI text #1139

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore(credentials): clean up UI text #1139

merged 1 commit into from
Oct 23, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Oct 16, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to #1119

image

image

@andrewazores andrewazores marked this pull request as draft October 16, 2023 13:42
@mergify mergify bot added the safe-to-test label Oct 16, 2023
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. backport labels Oct 16, 2023
@andrewazores andrewazores marked this pull request as ready for review October 19, 2023 18:59
@andrewazores andrewazores requested a review from mwangggg October 19, 2023 18:59
@andrewazores andrewazores force-pushed the store-credentials-info-text branch from 66cd89d to fbe72ff Compare October 20, 2023 13:53
@andrewazores andrewazores force-pushed the store-credentials-info-text branch from fbe72ff to 4635cfc Compare October 20, 2023 14:24
mwangggg
mwangggg approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrewazores andrewazores merged commit 316e9c7 into cryostatio:main Oct 23, 2023
18 checks passed
@andrewazores andrewazores deleted the store-credentials-info-text branch October 23, 2023 19:17
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
@andrewazores @mergify
chore(credentials): clean up UI text (#1139)
24100b0 
(cherry picked from commit 316e9c7)
@mergify mergify bot mentioned this pull request Oct 23, 2023
Merged
andrewazores added a commit that referenced this pull request Oct 23, 2023
@mergify @andrewazores
chore(credentials): clean up UI text (#1139) (#1144)
2cc2d37 
(cherry picked from commit 316e9c7)

Co-authored-by: Andrew Azores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwangggg mwangggg mwangggg approved these changes

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @mwangggg