Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(webhook): add test for Cryostat defaulter webhook #988

Merged
merged 1 commit into from
Dec 18, 2024
Merged

test(webhook): add test for Cryostat defaulter webhook #988

merged 1 commit into from
Dec 18, 2024

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Dec 17, 2024 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #987

Description of the change:

  • Adds tests for the Cryostat defaulting webhook
  • Reduces visibility of some types if not required to be public

Motivation for the change:

  • Increases test coverage

How to manually test:

  1. make test-envtest

@ebaron ebaron added the test label Dec 17, 2024
@ebaron ebaron requested a review from a team December 17, 2024 22:45
@mergify mergify bot added the safe-to-test label Dec 17, 2024
@ebaron
Copy link
Member Author

ebaron commented Dec 17, 2024

/build_test

@github-actions GitHub Actions
Copy link

/build_test completed successfully ✅.
View Actions Run.

@ebaron ebaron merged commit 9ea119d into cryostatio:main Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
safe-to-test test
Projects
4.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Cryostat defaulting webhook needs tests
2 participants
@ebaron @andrewazores