-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): add part-of, instance selector labels and appProtocol #974
Conversation
/build_test |
|
This PR + cryostatio/cryostat-openshift-console-plugin#2 leads to this situation. The Cryostat Service is correctly identified, but the Agent proxy service is, too. That proxy has the same |
/build_test |
|
2c535e1
to
55e723f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading this correctly, none of the selector labels have changed, so we shouldn't run into any immutable field errors upon upgrade.
Nothing relies on this, so renaming should be fine. |
I wonder if I can still do this - |
/build_test |
|
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #
See cryostatio/cryostat-helm#211
Related to cryostatio/cryostat-openshift-console-plugin#2
Description of the change:
This change adds allows the users to provide...
Motivation for the change:
This change is helpful because users may want to...
How to manually test: