Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): add part-of, instance selector labels and appProtocol #974

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #
See cryostatio/cryostat-helm#211
Related to cryostatio/cryostat-openshift-console-plugin#2

Description of the change:

This change adds allows the users to provide...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Insert steps here...
  2. ...

@mergify mergify bot added the safe-to-test label Nov 21, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

@andrewazores
Copy link
Member Author

image

This PR + cryostatio/cryostat-openshift-console-plugin#2 leads to this situation. The Cryostat Service is correctly identified, but the Agent proxy service is, too. That proxy has the same component: cryostat label on it - @ebaron does anything depend on that as a selector at this point, or can we change it?

@andrewazores andrewazores added the feat New feature or request label Nov 28, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this correctly, none of the selector labels have changed, so we shouldn't run into any immutable field errors upon upgrade.

@ebaron
Copy link
Member

ebaron commented Dec 17, 2024

@ebaron does anything depend on that as a selector at this point, or can we change it?

Nothing relies on this, so renaming should be fine.

@andrewazores andrewazores merged commit 75b7a81 into cryostatio:main Dec 17, 2024
5 checks passed
@andrewazores andrewazores deleted the service-labels branch December 17, 2024 16:42
@andrewazores andrewazores restored the service-labels branch December 17, 2024 19:08
@andrewazores
Copy link
Member Author

I wonder if I can still do this -

@andrewazores
Copy link
Member Author

/build_test

Copy link

/build_test : At least one test failed ❌.
View Actions Run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants