Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(proxy): add missing args to proxy expectations #845

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to #844 #839

Description of the change:

This change adds allows the users to provide...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Insert steps here...
  2. ...

@andrewazores
Copy link
Member Author

/build_test

@andrewazores andrewazores requested review from ebaron and tthvo June 5, 2024 13:30
Copy link

github-actions bot commented Jun 5, 2024

/build_test completed successfully ✅.
View Actions Run.

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! My branch was probably still behind cryostat3 in #844 :D

@andrewazores
Copy link
Member Author

Yep exactly. The branch protection rule that warns against this kind of "branch out of date" problem is only set up to apply to main and cryostat-vX.Y release branches, so it didn't appear on that PR.

@andrewazores andrewazores merged commit 5a7c4c3 into cryostatio:cryostat3 Jun 5, 2024
7 checks passed
@andrewazores andrewazores deleted the proxy-test-args branch June 5, 2024 19:08
@tthvo
Copy link
Member

tthvo commented Jun 5, 2024

Ahh make sense! I got the false impression that it was update-to-date...Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants