-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(grafana): remove separate Grafana service/route/ingress #809
Merged
andrewazores
merged 37 commits into
cryostatio:cryostat3
from
andrewazores:cryostat3-grafana-route
May 8, 2024
Merged
chore(grafana): remove separate Grafana service/route/ingress #809
andrewazores
merged 37 commits into
cryostatio:cryostat3
from
andrewazores:cryostat3-grafana-route
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
cryostat3-grafana-route
branch
from
May 6, 2024 17:35
701e50e
to
b30715c
Compare
andrewazores
force-pushed
the
cryostat3-grafana-route
branch
from
May 7, 2024 18:43
f615b02
to
2d2b618
Compare
7 tasks
This PR/issue depends on:
|
ebaron
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Depends on #808
Based on #808
Related to #710
Description of the change:
Grafana should now only be accessible through the auth proxy at the
/grafana
path. It should not have its own separate service, or Route/Ingress, because all traffic must flow through the auth proxy now.Motivation for the change:
This ensures that Grafana is only accessible using the same authn/authz as the rest of the application.
How to manually test:
OPENSHIFT_OAUTH_PROXY_IMG=quay.io/andrewazores/openshift-oauth-proxy:test-14
. Deploy Operator and create a Cryostat CR withenableCertManager: false
localhost:0
custom targethttps
scheme and the same domain, but should differ in the path - the Grafana dashboard should be athttps://cryostat-example.apps.crc-testing/grafana
. You should not need to re-login to view this./grafana
from the URL and you should go back to the Cryostat UI, without needing to re-login.oc get routes
andoc get services
and verify that there is only one Service/Route associated with the Cryostat instance, which points to port4180
- the authproxy HTTP port.