Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build-ci): fix scorecard image tag returned as null #760

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix(build-ci): fix scorecard image tag returned as null #760

merged 2 commits into from
Mar 15, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Mar 13, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to #698

Description of the change:

Updated CI to get scorecard tag from the 2nd test stage (custom scorecard) added in #698.

Motivation for the change:

The scorecard image is being built with tag null on upstream main.

CI: https://github.com/cryostatio/cryostat-operator/actions/runs/8161839436/job/22311468196

Quay: https://quay.io/repository/cryostat/cryostat-operator-scorecard?tab=tags

@tthvo tthvo requested review from andrewazores and ebaron March 13, 2024 09:02
ebaron
ebaron approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing the problem Thuan!

@ebaron ebaron merged commit 2201704 into cryostatio:main Mar 15, 2024
5 checks passed
@ebaron
Copy link
Member

ebaron commented Mar 15, 2024

@Mergifyio backport cryostat3

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 15, 2024 •
edited
Loading

backport cryostat3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 15, 2024
@tthvo @mergify
fix(build-ci): fix scorecard image tag returned as null (#760)
7abf61f 
Signed-off-by: Thuan Vo <[email protected]>
Co-authored-by: Elliott Baron <[email protected]>
(cherry picked from commit 2201704)
@mergify mergify bot mentioned this pull request Mar 15, 2024
Merged
7 tasks
ebaron pushed a commit that referenced this pull request Mar 15, 2024
@mergify @tthvo
fix(build-ci): fix scorecard image tag returned as null (#760) (#768)
8fd5307 
Signed-off-by: Thuan Vo <[email protected]>
Co-authored-by: Elliott Baron <[email protected]>
(cherry picked from commit 2201704)

Co-authored-by: Thuan Vo <[email protected]>
@tthvo tthvo deleted the build-ci branch March 17, 2024 01:06
@tthvo
Copy link
Member Author

tthvo commented Mar 18, 2024

https://github.com/cryostatio/cryostat-operator/actions/runs/8302678684/job/22725444182

Image:      ghcr.io/cryostatio/cryostat-operator-scorecard:ci-2201704822677f0e1ad94fee0d64250a7af2e67c
Entrypoint: [cryostat-scorecard-tests operator-install]
Labels:
	"test":"operator-install"
	"suite":"cryostat"
Results:
	State: fail

	Errors:
		pods "scorecard-test-x697" already exists

Randomized pod's name just happens to conflict? It's probably not our end...

@ebaron
Copy link
Member

ebaron commented Mar 19, 2024

That's really weird. You're right though, the scorecard-test pods are managed by Operator SDK.

@tthvo
Copy link
Member Author

tthvo commented Mar 19, 2024

https://github.com/operator-framework/operator-sdk/blob/4abd483aa4004af83b3c05ddf9d7a7e4d4653cc7/internal/scorecard/testpod.go#L41

Haha right. Maybe, another day of random not being actual so random :D

andrewazores added a commit that referenced this pull request Apr 23, 2024
@Josh-Matsuoka @mergify
@tthvo @andrewazores @mwangggg @ebaron
feat(deploy): deploy cryostat 3.0 (#727)
53d2b73 
* feat(discovery): options to configure discovery port names and numbers (backport #715) (#725)

* feat(discovery): options to configure discovery port names and numbers (#715)

Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit a552021)

* resolve conflict

---------

Co-authored-by: Thuan Vo <[email protected]>
Co-authored-by: Andrew Azores <[email protected]>

* Deploy cryostat 3.0

* Remove extraneous file

* test adjustments

* feat(discovery): options to configure discovery port names and numbers (#715)

Signed-off-by: Thuan Vo <[email protected]>

* Fix typo in environment variable breaking reconciler test, fix missing SecurityContext

* Fix conflict with cluster cryostat removal

* ci(gh): add comment when /build_test is finished (#745)

* add scorecard test/suite selection (#746)

* test(scorecard): scorecard tests for recording management (#698)

* test(scorecard): scorecard tests for recording management

Signed-off-by: Thuan Vo <[email protected]>

* fixup(scorecard): fix cr cleanup func

* test(scorecard): registry recording test to suite

* chore(scorecard): reorganize client def

* chore(scorecard): clean up common setup func

* chore(bundle): regenerate bundle with scorecard tag

* chore(bundle): correct image tag in bundle

* fix(bundle): add missing scorecard test config patch

* feat(scorecard): scaffold cryostat API client

* chore(scorecard): clean up API client

* test(scorecard): implement recording scorecard test

* fixup(scorecard): correctly add scorecard test via hack templates

* fix(client): ignore unverified tls certs and base64 oauth token

* chore(bundle): split cryostat tests to separate stage

* fix(scorecard): extend default transport instead of overwriting

* chore(scorecard): refactor client to support multi-part

* fixup(client): fix request verb

* fix(client): fix recording create form format

* fix(scorecard): create stored credentials for target JVM

* fix(scorecard): fix 502 status error

* chore(scorecard): simplify client def

* chore(scorecard): fetch recordings to ensure action is correctly performed

* test(scorecard): test generating report for a recording

* chore(scorecard): clean up

* test(scorecard): list archives in tests

* ci(scorecard): reconfigure ingress for kind

* ci(k8s): correct cluster name

* test(scorecard): use role instead of clusterrole for oauth rules

* test(scorecard): parse health response for additional checks

* chore(scorecard): add missing newline in logs

* chore(scorecard): check status code before parsing body in health check

* test(scorecard): add custom target discovery to recording scorecard test

* add EOF wait and resp headers

* add resp headers

* chore(client): configure all clients to send safe requests

* fix(clients): add missing content-type header

* fix(scorecard): add missing test name in help message

* chore(client): create new http requests when retrying

* chore(bundle): update scorecard image tags

---------

Signed-off-by: Thuan Vo <[email protected]>
Co-authored-by: Ming Yu Wang <[email protected]>
Co-authored-by: Ming Wang <[email protected]>

* test(scorecard): scorecard test for Cryostat CR configuration changes (#739)

* CR config scorecard

* reformat

* reviews

* add kubectl license

* test(scorecard): scorecard test for report generator  (#753)

* deploy reports sidecar

* report scorecard test

* update

* rebase fix

* query health

* fix(build-ci): fix scorecard image tag returned as null (#760)

Signed-off-by: Thuan Vo <[email protected]>
Co-authored-by: Elliott Baron <[email protected]>

* test(scorecard): add container logs to scorecard results (#758)

* test(scorecard): add container logs to scorecard results

* build(bundle): regenerate bundle with new scorecard tags

* chore(scorecard): refactor to remove duplicate codes

* add permission to publish comment when ci fails (#769)

Co-authored-by: Elliott Baron <[email protected]>

* Update NewCoreContainer and associated tests

* build(go): update Golang to 1.21 (#777)

* test(scorecard): logWorkloadEvent for cryostat-recording errors (#759)

* logWorkLoadEvent for cryostat-recording errors

* reviews

* tr.LogChannel

---------

Co-authored-by: Elliott Baron <[email protected]>

* test(scorecard): fix rebasing skipped commit (#780)

* Merge pull request #8 from ebaron/scorecard-methods

test(scorecard): use methods for more easily passing data

* update bundle image

* Review fixes

* generate storage key, create expected Secret

* fixup! generate storage key, create expected Secret

* database secret handling corrections

* combine database connection password and encryption key into one secret

* correct storage secret key/access key

* update datasource port number to not conflict with storage

* precreate eventtemplates bucket

* remove storage volume parameter overrides

* use HTTP for Cryostat probe even when TLS is enabled - TLS will be done via auth proxy later

* correct environment variable names for proxy awareness

* Fix remaining merge conflict

* Fix makefile

* config cleanup and test fixup

---------

Signed-off-by: Thuan Vo <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Thuan Vo <[email protected]>
Co-authored-by: Andrew Azores <[email protected]>
Co-authored-by: Ming Yu Wang <[email protected]>
Co-authored-by: Ming Wang <[email protected]>
Co-authored-by: Elliott Baron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
ci fix safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tthvo @ebaron @andrewazores