Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): remove CommandConfig from NetworkOptions #743

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

mwangggg
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #730

@mwangggg
Copy link
Member Author

/build_test

@mwangggg
Copy link
Member Author

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @mwangggg! Could I get you do add a test case for this like this one?

return append(tableEntries(), Entry("WS connections", (*test.TestResources).NewCryostatWithWsConnectionsSpecV1Beta1,
(*test.TestResources).NewCryostat))

I don't think we have any existing test function to create an CR with CommandConfig set, but the existing helper functions in the call graph here might make it simple:

func (r *TestResources) NewCryostatWithIngressV1Beta1() *operatorv1beta1.Cryostat {
return r.addIngressToCryostatV1Beta1(r.NewCryostatV1Beta1())
}

api/v1beta1/cryostat_types.go Outdated Show resolved Hide resolved
@mwangggg mwangggg force-pushed the 730-remove-ComandConfig branch 3 times, most recently from 79765e2 to 3e9b049 Compare March 8, 2024 17:32
@mwangggg mwangggg force-pushed the 730-remove-ComandConfig branch from f0d0431 to aac6cc8 Compare March 11, 2024 18:58
@ebaron
Copy link
Member

ebaron commented Mar 11, 2024

/build_test

internal/test/conversion.go Outdated Show resolved Hide resolved
@mwangggg mwangggg force-pushed the 730-remove-ComandConfig branch from 86e0eac to dfc8401 Compare March 12, 2024 21:12
@ebaron
Copy link
Member

ebaron commented Mar 15, 2024

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Ming!

@ebaron ebaron added the chore Refactor, rename, cleanup, etc. label Mar 15, 2024
@ebaron ebaron merged commit 5917c22 into cryostatio:cryostat3 Mar 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants