chore(api): remove MaxWsConnections #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwangggg
added
chore
mwangggg
requested review from
ebaron and
andrewazores
and removed request for
ebaron
mwangggg
force-pushed
the
729-remove-MaxWsConnections
branch
from
74c1aad to
df885d7
Compare
|
/build_test |
|
just realized that this may be subject to change according to #727. I can put in a dependency on it if we want to wait for that PR to be merged first. |
|
I think it makes sense for this to be merged into the cryostat3 branch along with the other changes Josh is currently working on. |
api/v1beta1/cryostat_types.go
Outdated
| // +optional | ||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Max WebSocket Connections",xDescriptors={"urn:alm:descriptor:com.tectonic.ui:number"} | ||
| // +kubebuilder:validation:Minimum=1 | ||
| MaxWsConnections int32 `json:"maxWsConnections,omitempty"` |
There was a problem hiding this comment.
I guess maybe this should be kept in the v1beta1 spec so that it doesn't break API compatibility, but the value would actually just be ignored by the implementation and not handled on upgrades to v1beta2.
ebaron
reviewed
Feb 28, 2024
mwangggg
force-pushed
the
729-remove-MaxWsConnections
branch
from
81b028a to
3362bb9
Compare
mwangggg
force-pushed
the
729-remove-MaxWsConnections
branch
from
3362bb9 to
66b19e9
Compare
ebaron
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Fixes: #729