feat(csv): require AllNamespaces install mode #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebaron
added
feat
|
Line 49 in 6ac7ec6 I guess this variable can be removed and the value hardcoded? |
andrewazores
approved these changes
Feb 12, 2024
andrewazores
pushed a commit
that referenced
this pull request
Feb 22, 2024
* feat(csv): require AllNamespaces install mode * Remove unused function * Remove install mode variable from Makefile
mwangggg
pushed a commit
to mwangggg/cryostat-operator
that referenced
this pull request
Feb 29, 2024
* feat(csv): require AllNamespaces install mode * Remove unused function * Remove install mode variable from Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Fixes: #718
Description of the change:
Motivation for the change:
One drawback is that users of 2.x that installed the operator with one of these removed modes will need to uninstall the operator and reinstall using AllNamespaces.
How to manually test: