chore(build): upgrade Operator SDK to v1.31.0

[aali309]

Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

---

Fixes: #614

Description of the change:

This change upgrades Operator SDK v1.28.0. to the newest available version at the moment (v1.31.0.)

Motivation for the change:

upgrade to the latest available version

How to manually test:

1. Insert steps here...
2. ...

[tthvo]

Looks like Makefile was updated such that operator-sdk can be installed and referenced from ./bin. Tho, it seems to ignore if there is a system installation.

https://github.com/operator-framework/operator-sdk/blob/e67da35ef4fff3e471a208904b2a142b27ae32b1/testdata/go/v3/memcached-operator/Makefile#L214

We should sync with these changes?

[ebaron]

Looks like Makefile was updated such that operator-sdk can be installed and referenced from ./bin. Tho, it seems to ignore if there is a system installation.

https://github.com/operator-framework/operator-sdk/blob/e67da35ef4fff3e471a208904b2a142b27ae32b1/testdata/go/v3/memcached-operator/Makefile#L214

We should sync with these changes?

I think this is a good idea. Let's bring in this block into our Makefile: https://github.com/operator-framework/operator-sdk/blob/8f24aa560c1b8a8ea7bbc062016347b4012e499c/testdata/go/v3/memcached-operator/Makefile#L213-L228

Then anywhere we call operator-sdk in the Makefile, we should replace it with $(OPERATOR_SDK) and add the new operator-sdk target as a prerequisite for the target containing the operator-sdk call.

Once that's done we can remove the setup-operator-sdk step from our GitHub workflow:

cryostat-operator/.github/workflows/test-ci-reusable.yml

Lines 63 to 65 in 17d7420

	- uses: jpkrohling/[email protected]
	with:
	operator-sdk-version: v1.28.0

Edit: We'll need this block too: https://github.com/operator-framework/operator-sdk/blob/8f24aa560c1b8a8ea7bbc062016347b4012e499c/testdata/go/v3/memcached-operator/Makefile#L49-L51

[tthvo]

Sounds good! Make sense to me!

[ebaron]

Thanks for doing this extra bit @aali309. The only thing I see missing is to add the new operator-sdk target as a prerequisite for targets like test-scorecard that use the new $(OPERATOR_SDK) variable.

Something like:
test-scorecard: check_cert_manager kustomize operator-sdk

[tthvo]

Looks good to me!

[aali309]

ping @ebaron @andrewazores

[ebaron]

Looks good. Thanks @aali309!

[aali309]

Looks good. Thanks @aali309!

No man thanks to you @ebaron @andrewazores and @tthvo