Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(liveness): execute on worker pool #1779

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix(liveness): execute on worker pool #1779

merged 1 commit into from
Nov 17, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 17, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to: #1778

@mergify mergify bot added the safe-to-test label Nov 17, 2023
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link
Contributor

Workflow started at 11/17/2023, 10:55:30 AM. View Actions Run.

@andrewazores andrewazores requested a review from ebaron November 17, 2023 15:58
@andrewazores andrewazores marked this pull request as ready for review November 17, 2023 15:59
@github-actions GitHub Actions
Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1779-11f397ac5a1b70b14a7ff6a0d613ffe6628b4f68-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1779-11f397ac5a1b70b14a7ff6a0d613ffe6628b4f68-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1779-11f397ac5a1b70b14a7ff6a0d613ffe6628b4f68-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1779-11f397ac5a1b70b14a7ff6a0d613ffe6628b4f68-linux-arm64 sh smoketest.sh

@github-actions GitHub Actions
Copy link
Contributor

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores merged commit 9287edf into cryostatio:main Nov 17, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Nov 17, 2023
@andrewazores @mergify
fix(liveness): execute on worker pool (#1779)
01ba1ad 
(cherry picked from commit 9287edf)
@mergify mergify bot mentioned this pull request Nov 17, 2023
Merged
andrewazores added a commit that referenced this pull request Nov 17, 2023
@mergify @andrewazores
fix(liveness): execute on worker pool (#1779) (#1780)
8f7a234 
(cherry picked from commit 9287edf)

Co-authored-by: Andrew Azores <[email protected]>
@andrewazores andrewazores deleted the worker-pool-liveness branch November 17, 2023 17:54
@andrewazores andrewazores mentioned this pull request Nov 17, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
backport fix safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @ebaron