Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): exclude slf4j from vertx bom #1743

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1742

Description of the change:

Excludes slf4j artifacts from the vertx-dependencies bom. We define our own version and scopes.

Motivation for the change:

This restores missing log messages since #1720.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. Check server logs for messages like:
INFO: Observing new target: io.cryostat.platform.ServiceRef@1eea678c[alias=io.cryostat.Cryostat,annotations=io.cryostat.platform.ServiceRef$Annotations@55e20de0[cryostat={HOST=cryostat, PORT=9091, JAVA_MAIN=io.cryostat.Cryostat, REALM=JDP},platform={}],jvmId=<null>,labels={},serviceUri=service:jmx:rmi:///jndi/rmi://cryostat:9091/jmxrmi]
...
INFO: Outgoing WS message: {"meta":{"category":"WsClientActivity","type":{"type":"application","subType":"json"}},"message":{"10.0.2.100:35544":"connected"}}
...
INFO: Outgoing WS message: {"meta":{"category":"WsClientActivity","type":{"type":"application","subType":"json"}},"message":{"10.0.2.100:35544":"accepted"}}

@andrewazores andrewazores requested a review from a team as a code owner October 24, 2023 19:41
@andrewazores andrewazores added dependencies Pull requests that update a dependency file fix safe-to-test labels Oct 24, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Oct 24, 2023
@andrewazores andrewazores changed the title chore(pom): exclude slf4j from vertx bom fix(logging): exclude slf4j from vertx bom Oct 24, 2023
@andrewazores andrewazores added backport and removed needs-triage Needs thorough attention from code reviewers labels Oct 24, 2023
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yay logs!

@andrewazores
Copy link
Member Author

/build_test

@mwangggg
Copy link
Member

@github-actions
Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1743-75bbd03ff8998f16d7f3abc9b0909a66b26ff352-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1743-75bbd03ff8998f16d7f3abc9b0909a66b26ff352-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1743-75bbd03ff8998f16d7f3abc9b0909a66b26ff352-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1743-75bbd03ff8998f16d7f3abc9b0909a66b26ff352-linux-arm64 sh smoketest.sh

@andrewazores andrewazores force-pushed the vertx-slf4j-exclusion branch from 75bbd03 to 365b24c Compare October 24, 2023 20:29
@andrewazores andrewazores merged commit f6b03ad into cryostatio:main Oct 25, 2023
7 checks passed
@andrewazores andrewazores deleted the vertx-slf4j-exclusion branch October 25, 2023 13:10
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
andrewazores added a commit that referenced this pull request Oct 25, 2023
(cherry picked from commit f6b03ad)

Co-authored-by: Andrew Azores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport dependencies Pull requests that update a dependency file fix safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Missing log output since #1720
4 participants