chore(reports): remove HTML report generation #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andrewazores! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
github-actions
bot
added
needs-triage
|
Hi @andrewazores! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
7 tasks
andrewazores
added
breaking change
andrewazores
force-pushed
the
rules-analysis-fields
branch
from
4f785c3 to
4229e1c
Compare
|
/build_test |
|
Oh right, won't be able to do a build_test until the corresponding -core release is made. |
andrewazores
force-pushed
the
rules-analysis-fields
branch
from
4229e1c to
c5cf334
Compare
|
This PR/issue depends on: |
|
/build_test |
To run smoketest: |
andrewazores
force-pushed
the
rules-analysis-fields
branch
from
c5cf334 to
1f9a7af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainDepends on cryostatio/cryostat-core#261
Related to cryostatio/cryostat-reports#137
Description of the change:
Removes the HTML-based report generation in favour of only the newer JSON generation.
Motivation for the change:
HTML report generation forced us to use the JMC-styled HTML reports in our UI. We have our own nicely-styled Patternfly component based reports UI that consumes JSON API responses instead, so the HTML UI should be removed and the API for generating it along with it.
How to manually test: