Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update PR actions to node16 #1680

Merged
merged 26 commits into from
Sep 21, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Sep 21, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1641

Description of the change:

This change updates the node version from 12 that is deprecated to v16 by updating actions/checkout@v2 to v4

Motivation for the change:

This change is helpful because it will get rid of the warning when running PR workflows because node12 is deprecated

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@andrewazores
Copy link
Member

@aali309 is this meant to be a draft still or ready?

@aali309
Copy link
Contributor Author

aali309 commented Sep 21, 2023

@aali309 is this meant to be a draft still or ready?

was just reading something to make sure, but it looks like its ready I think, main thing needed was to change the actions/checkout

@aali309 aali309 marked this pull request as ready for review September 21, 2023 19:49
@andrewazores andrewazores merged commit 0906a04 into cryostatio:main Sep 21, 2023
12 checks passed
@andrewazores
Copy link
Member

@tthvo
Copy link
Member

tthvo commented Sep 24, 2023

Well Node 20 is coming this Spring 2024: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@aali309 aali309 deleted the updatePRactionstonode16 branch October 31, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Upgrade PR actions to versions that use node16
3 participants