Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GraphQL): Add GraphQL filter ability for node name from set #1518

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Jun 5, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1433

Description of the change:

This change adds allows filtering of multiple names instead of just one name

Motivation for the change:

This change is helpful because one can now filter multiple matching names with just one request instead of filtering one name at time for each request

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
    • mvn clean verify *
    • mvn clean verify -Dit=tests=GraphQLIT.java*

@aali309 aali309 changed the title fix(GraphQL):Adding GraphQL multiple names filter ability fix (GraphQL): Adding GraphQL multiple names filter ability Jun 5, 2023
@aali309 aali309 changed the title fix (GraphQL): Adding GraphQL multiple names filter ability fix(GraphQL): Adding GraphQL multiple names filter ability 2.3.0 to 2.4.0 Jun 5, 2023
@aali309 aali309 changed the title fix(GraphQL): Adding GraphQL multiple names filter ability 2.3.0 to 2.4.0 Task(GraphQL): Adding GraphQL multiple names filter ability 2.3.0 to 2.4.0 Jun 5, 2023
@aali309 aali309 changed the title Task(GraphQL): Adding GraphQL multiple names filter ability 2.3.0 to 2.4.0 Task(GraphQL): Adding GraphQL multiple names filter ability from 2.3.0 to 2.4.0 Jun 5, 2023
@aali309 aali309 changed the title Task(GraphQL): Adding GraphQL multiple names filter ability from 2.3.0 to 2.4.0 feat(GraphQL): Adding GraphQL multiple names filter ability from 2.3.0 to 2.4.0 Jun 5, 2023
@aali309 aali309 changed the title feat(GraphQL): Adding GraphQL multiple names filter ability from 2.3.0 to 2.4.0 feat(GraphQL): Add GraphQL filter ability for node name from set Jun 5, 2023
@aali309 aali309 added the feat New feature or request label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-24e77bd9f2cf7ab14f4cd38e050a5807fe2b82e2 sh smoketest.sh

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-1934b3d952e5bde167fa43b82b3de3cebfba1317 sh smoketest.sh

@aali309 aali309 force-pushed the 1433_AddGraphQLFilter branch 2 times, most recently from 5e6e9fc to a7d33cb Compare June 10, 2023 07:16
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request blocked. web-client submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.

mergify[bot]
mergify bot previously requested changes Jun 10, 2023
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request blocked. web-client submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.

@aali309 aali309 closed this Jun 10, 2023
@aali309 aali309 reopened this Jun 10, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jun 10, 2023
@aali309 aali309 closed this Jun 10, 2023
@aali309 aali309 reopened this Jun 10, 2023
@aali309 aali309 removed safe-to-test needs-triage Needs thorough attention from code reviewers labels Jun 10, 2023
@aali309 aali309 closed this Jun 10, 2023
@aali309 aali309 reopened this Jun 10, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jun 10, 2023
@aali309 aali309 marked this pull request as ready for review June 10, 2023 08:06
@aali309 aali309 requested a review from ebaron as a code owner June 10, 2023 08:06
@aali309 aali309 requested a review from andrewazores June 12, 2023 13:26
@aali309 aali309 closed this Jun 12, 2023
@aali309 aali309 reopened this Jun 12, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-30c8851b7f6a062b3179df5f5f38c60a1744cc37-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-30c8851b7f6a062b3179df5f5f38c60a1744cc37-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-18b045a05d93368030ed35b08563927ceb2fe3cc-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-18b045a05d93368030ed35b08563927ceb2fe3cc-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-a514f825d6d067d565d545a4dcab7a4520a6047b-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-a514f825d6d067d565d545a4dcab7a4520a6047b-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-c19261e2e2bbc52de42c93b4c521af0c9910b245-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-c19261e2e2bbc52de42c93b4c521af0c9910b245-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-53ef07ef1538f38905032d1150b8a78af8a03842-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-53ef07ef1538f38905032d1150b8a78af8a03842-linux-amd64 sh smoketest.sh

@andrewazores
Copy link
Member

Looks good! Please rebase and I will merge this.

@aali309 aali309 force-pushed the 1433_AddGraphQLFilter branch from 53ef07e to b2bd920 Compare June 27, 2023 16:32
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-b2bd920b058c0f5aadd86be0cf800e9373a8f014-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1518-b2bd920b058c0f5aadd86be0cf800e9373a8f014-linux-amd64 sh smoketest.sh

@andrewazores andrewazores merged commit 3352d27 into cryostatio:main Jun 27, 2023
@aali309 aali309 deleted the 1433_AddGraphQLFilter branch June 27, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Add GraphQL filter ability for node name from set
2 participants