-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GraphQL): Add GraphQL filter ability for node name from set #1518
Conversation
Test image available:
|
Test image available:
|
5e6e9fc
to
a7d33cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request blocked. web-client
submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client
submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request blocked. web-client
submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the web-client
submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
src/main/java/io/cryostat/net/web/http/api/v2/graph/ActiveRecordingsFetcher.java
Outdated
Show resolved
Hide resolved
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
Looks good! Please rebase and I will merge this. |
53ef07e
to
b2bd920
Compare
Test image available:
|
Test image available:
|
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1433
Description of the change:
This change adds allows filtering of multiple names instead of just one name
Motivation for the change:
This change is helpful because one can now filter multiple matching names with just one request instead of filtering one name at time for each request
How to manually test: