-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(threads): revert #1388 #1467
fix(threads): revert #1388 #1467
Conversation
692cd51
to
e83e369
Compare
Test image available:
|
e83e369
to
db10e6f
Compare
This PR/issue depends on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nothing seems to break from using jmx/agent credentials.
db10e6f
to
e6e8791
Compare
Test image available:
|
e6e8791
to
947aedf
Compare
Test image available:
|
947aedf
to
6f92881
Compare
Test image available:
|
cryostatio#1388)" This reverts commit 39695d0.
Signed-off-by: Andrew Azores <[email protected]>
6f92881
to
af7eafa
Compare
Test image available:
|
Rebased several times to include changes to |
* Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" This reverts commit 39695d0. * compile fixes Signed-off-by: Andrew Azores <[email protected]> * fixup! Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" --------- Signed-off-by: Andrew Azores <[email protected]> (cherry picked from commit eaf801a)
* Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" This reverts commit 39695d0. * compile fixes Signed-off-by: Andrew Azores <[email protected]> * fixup! Revert "fix(credentials): store JMX session credentials in ThreadLocal (#1388)" --------- Signed-off-by: Andrew Azores <[email protected]> (cherry picked from commit eaf801a) Co-authored-by: Andrew Azores <[email protected]>
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Related to #1448
Related to #1449
Depends on #1466
Back out #1388 completely. This will break JMX session credentials again but should put the threading interactions back into a working (still not proper) condition. Needs more thorough testing to be sure however.