-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(graphql): add graphql unit tests #1060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have written tests for the fetcher and mutator implementations and surface level tests for the handlers. I have a few questions overall.
|
|
I've fixed everything that I can see and most of the GraphQL stuff should be covered. Thoughts or anything I've missed? |
…gFetcherTests, all other actual GraphQL endpoints, i.e. Get, Post, GraphiQLGet, etc...
…er, removed a test, etc.
andrewazores
force-pushed
the
graph-ql-tests
branch
from
September 6, 2022 18:15
55d1077
to
f7b7fec
Compare
andrewazores
approved these changes
Sep 6, 2022
Awesome, thanks for doing all of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947