feat(secrets): enable user-supplied storage and authproxy secrets #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
reviewed
Sep 6, 2024
andrewazores
force-pushed
the
user-supplied-secrets
branch
from
e585fee to
562710e
Compare
tthvo
reviewed
Sep 6, 2024
andrewazores
added
the
breaking change
|
I guess we are waiting on response in #187? Maybe we can move forward and when the all changes are merged on |
|
Yes, I say we go ahead. It would be easier for Grzegorz to test anyway if it was merged, I think, and if there are any other fixes required we can do them as separate PRs. |
andrewazores
force-pushed
the
user-supplied-secrets
branch
from
6850b16 to
0d1dea6
Compare
andrewazores
force-pushed
the
separate-db-storage
branch
from
fad64c0 to
0d0b633
Compare
|
Hmm some issues during rebasing? Some conflicts seem to be reported and the change diffs are a bit odd :D |
|
Ah, I think I just rebased it onto main instead of the separate-db-storage branch. |
andrewazores
force-pushed
the
user-supplied-secrets
branch
from
0d1dea6 to
bf2af72
Compare
andrewazores
force-pushed
the
separate-db-storage
branch
from
0d0b633 to
fdbc6b9
Compare
andrewazores
force-pushed
the
user-supplied-secrets
branch
from
bf2af72 to
b962ec5
Compare
tthvo
reviewed
Sep 18, 2024
andrewazores
force-pushed
the
user-supplied-secrets
branch
from
b962ec5 to
22009bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188