Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deployment): remove unused containerPort spec (backport #153) #155

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 12, 2024

Related to #140

Descriptions

Removed unused containerPort in Cryostat container's spec. The list is actually immutable but since deployment rollout strategy is Recreate, updating across upgrades is possible.

$ oc explain pod.spec.containers.ports
KIND:       Pod
VERSION:    v1

FIELD: ports <[]ContainerPort>

DESCRIPTION:
    List of ports to expose from the container. Not specifying a port here DOES
    NOT prevent that port from being exposed. Any port which is listening on the
    default "0.0.0.0" address inside a container will be accessible from the
    network. Modifying this array with strategic merge patch may corrupt the
    data. For more information See
    https://github.com/kubernetes/kubernetes/issues/108255. Cannot be updated.
    ContainerPort represents a network port in a single container.

```<hr>This is an automatic backport of pull request #153 done by [Mergify](https://mergify.com).

@mergify mergify bot assigned tthvo Jun 12, 2024
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Jun 12, 2024
@andrewazores andrewazores merged commit d790441 into cryostat-v3.0 Jun 12, 2024
7 of 8 checks passed
@mergify mergify bot deleted the mergify/bp/cryostat-v3.0/pr-153 branch June 12, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants