Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(multiarch): build multiarch using GitHub Actions #38

Merged
merged 2 commits into from
Aug 15, 2023
Merged

ci(multiarch): build multiarch using GitHub Actions #38

merged 2 commits into from
Aug 15, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 14, 2023 •
edited
Loading

@andrewazores andrewazores marked this pull request as ready for review August 14, 2023 20:04
@andrewazores andrewazores requested review from ebaron and tthvo August 14, 2023 20:05
tthvo
tthvo reviewed Aug 14, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
tthvo
tthvo reviewed Aug 14, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
tthvo
tthvo approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me!

ebaron
ebaron approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One RFE for later, this tags releases with the v prefix intact. It would be nice to strip this from the tag name when tagging the container image (e.g. v2.4.0 -> 2.4.0) to be consistent with other components.

@andrewazores andrewazores merged commit 361795d into cryostatio:main Aug 15, 2023
@andrewazores andrewazores deleted the multiarch-ci branch August 15, 2023 13:44
@andrewazores andrewazores mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
ci
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewazores @ebaron @tthvo