feat(ini): allow embedding #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
andrewazores
force-pushed
the
grafana-embed
branch
from
dcbda8d to
1356da9
Compare
|
@ebaron ping |
ebaron
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cryostatio/cryostat-web#847 . This adds a config line that tells the Grafana server to allow embedded panels, ex. via
<iframe>element, on other pages (such as the Cryostat web-client). Without this, the Grafana server adds headers to requests that instruct web browsers to not load/render content cross-origin.https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#allow_embedding