-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): new design for dashboard #12
Conversation
This just ensures the data is visible at least until this feature grafana/grafana#6288 is implemented :D |
There's still a Zoom Out button near the top right corner of the dashboard screen, right? If so, I think a narrower default time range would be better. A year-long JFR file would probably be prohibitively large in size and unlikely to load at all. I think just the past hour would be a better middleground default. Good chance the recording is shorter so the user needs to zoom in somewhat, but it may also be somewhat longer so the user might need to zoom out using the top date range toolbar controls. |
Right! That makes sense! Then, I restore it back to last 24-h as we had previously. |
aa18885
to
30ddbdb
Compare
The corresponding datasource PR just needs tests fixed so I think you can test them out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, looks great!
Fixes #11
Fixes #2
Depends on cryostatio/jfr-datasource#135
What's new?
Cryostat Dashboard
.24h-ago <-> now
.