Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): new design for dashboard #12

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 28, 2022

Fixes #11
Fixes #2
Depends on cryostatio/jfr-datasource#135

What's new?

  • Main dashboard name is now Cryostat Dashboard.
  • Events are placed in their respective categories.
  • Graph now displays correct units (i.e. no more ~23 PETAbytes memory usage :d)
  • Default time frame is set to 24h-ago <-> now.
  • A separate dashboard with filters for jdk.ObjectAllocationSample.
  • Each "sub" dashboard should have direct link back to the Main Dashboard.
  • Dashboard will open main Cryostat Dashboard on launch.
  • Duration and Start time of recording is fixed for any time frame of a single recording. See comment.

@tthvo
Copy link
Member Author

tthvo commented Sep 28, 2022

Default time frame is set to 1-year-ago - now.

This just ensures the data is visible at least until this feature grafana/grafana#6288 is implemented :D

@andrewazores
Copy link
Member

There's still a Zoom Out button near the top right corner of the dashboard screen, right? If so, I think a narrower default time range would be better. A year-long JFR file would probably be prohibitively large in size and unlikely to load at all. I think just the past hour would be a better middleground default. Good chance the recording is shorter so the user needs to zoom in somewhat, but it may also be somewhat longer so the user might need to zoom out using the top date range toolbar controls.

@tthvo
Copy link
Member Author

tthvo commented Sep 28, 2022

There's still a Zoom Out button near the top right corner of the dashboard screen, right? If so, I think a narrower default time range would be better. A year-long JFR file would probably be prohibitively large in size and unlikely to load at all. I think just the past hour would be a better middleground default. Good chance the recording is shorter so the user needs to zoom in somewhat, but it may also be somewhat longer so the user might need to zoom out using the top date range toolbar controls.

Right! That makes sense! Then, I restore it back to last 24-h as we had previously.

@tthvo tthvo force-pushed the redesign-dashboard branch from aa18885 to 30ddbdb Compare September 28, 2022 23:42
@tthvo tthvo added the feat New feature or request label Sep 28, 2022
@tthvo tthvo marked this pull request as ready for review September 28, 2022 23:53
@tthvo
Copy link
Member Author

tthvo commented Sep 29, 2022

The corresponding datasource PR just needs tests fixed so I think you can test them out.

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work.

Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, looks great!

@andrewazores andrewazores merged commit f9a81f6 into cryostatio:main Sep 29, 2022
@tthvo tthvo deleted the redesign-dashboard branch September 29, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Redesign Grafana Dashboard Should the default dashboard be named "Dashboard"?
3 participants