-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): test -core's build in Cryostat image #266
Conversation
8d6c04d
to
2615a8f
Compare
demo: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Just some questions. Also, why not explore pushing the test image to ghcr.io
instead of saving as an aritifacts?
This way, we can output the test image + rerun tests without building too.
9033b38
to
ec8c560
Compare
c2a06a2
to
53f387e
Compare
a3d8371
to
f59e503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
8be710f
to
9d3dc1c
Compare
0b0e4b7
to
54808f4
Compare
856c902
to
0744db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #266 (comment)
So, setup-java
with cache: maven
should cache and restore the -core
build in a specific workflow run (i.e. a specific PR). Lets try it out?
testing :mwangggg#2 |
a281b8e
to
2767893
Compare
7cbddb3
to
cb5e497
Compare
8ae4bbc
to
fae253c
Compare
/build_test |
fixes: #221