Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): test -core's build in Cryostat image #266

Closed
wants to merge 6 commits into from

Conversation

mwangggg
Copy link
Member

fixes: #221

@mwangggg
Copy link
Member Author

demo: run

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just some questions. Also, why not explore pushing the test image to ghcr.io instead of saving as an aritifacts?

This way, we can output the test image + rerun tests without building too.

@mwangggg
Copy link
Member Author

mwangggg commented Oct 2, 2023

@mwangggg mwangggg force-pushed the 221-cryostat-IT branch 2 times, most recently from c2a06a2 to 53f387e Compare October 2, 2023 17:36
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mwangggg mwangggg force-pushed the 221-cryostat-IT branch 3 times, most recently from 0b0e4b7 to 54808f4 Compare October 5, 2023 19:23
@mwangggg mwangggg force-pushed the 221-cryostat-IT branch 3 times, most recently from 856c902 to 0744db7 Compare October 5, 2023 20:27
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #266 (comment)

https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache

So, setup-java with cache: maven should cache and restore the -core build in a specific workflow run (i.e. a specific PR). Lets try it out?

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/cryostat-build.yml Outdated Show resolved Hide resolved
.github/workflows/cryostat-build.yml Outdated Show resolved Hide resolved
.github/workflows/cryostat-build.yml Outdated Show resolved Hide resolved
.github/workflows/cryostat-build.yml Outdated Show resolved Hide resolved
.github/workflows/cryostat-build.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@mwangggg mwangggg added the feat New feature or request label Oct 6, 2023
@mwangggg
Copy link
Member Author

mwangggg commented Oct 6, 2023

testing :mwangggg#2

@mwangggg
Copy link
Member Author

/build_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] PR CI should test -core changes in a Cryostat container image against existing itests
4 participants