Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tls): make Keystore password optional #534

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Nov 14, 2024

This PR modifies the TLS server setup to not require a keystore password, but use it if provided. This makes the operator's agent auto-configuration simpler by not having to generate a secret in each target namespace, and follows cert-manager's best practices.

Fixes: #533

@ebaron ebaron added the feat New feature or request label Nov 14, 2024
@ebaron ebaron requested a review from a team November 14, 2024 20:32
@mergify mergify bot added the safe-to-test label Nov 14, 2024
@andrewazores andrewazores merged commit fc86465 into cryostatio:main Nov 14, 2024
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Make Keystore password optional
2 participants