feat(management): avoid self-referencing JMX operations #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
added
feat
andrewazores
force-pushed
the
no-self-jmx-connection
branch
3 times, most recently
from
e9986d0 to
35809e1
Compare
andrewazores
force-pushed
the
no-self-jmx-connection
branch
from
35809e1 to
5b352dc
Compare
mwangggg
reviewed
Dec 11, 2023
mwangggg
reviewed
Dec 11, 2023
|
Hmm. I'm not seeing that. Which target did you have selected? Did this only happen after you tried to expand the automated analysis? |
andrewazores
force-pushed
the
no-self-jmx-connection
branch
from
5b352dc to
7668f11
Compare
Oh I think I was using an out of date -core. I updated everything and reran and it is working as expected now :) |
… JFRConnectionToolkit and JMX calls
…ed with mutations
andrewazores
force-pushed
the
no-self-jmx-connection
branch
from
830e7ca to
09ee607
Compare
|
Rebased just to drop some accidentally included unrelated changes to the |
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
(cherry picked from commit 5a13941)
andrewazores
added a commit
that referenced
this pull request
Dec 11, 2023
(cherry picked from commit 5a13941) Co-authored-by: Andrew Azores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278
Depends on cryostatio/cryostat-core#309
Depends on cryostatio/cryostat-core#313
Depends on #289
Depends on #293
TODO before merge: correct-coreversion inpom.xmlto point to a newly-released upstream version, not the-SNAPSHOTas it is for testing purposes in this PR