Clean URLs with and without trailing slash #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good to me (I haven't tested yet either though 😄) Are you going to be adding more to this PR? |
|
Assuming this works, this specific PR won't need anything additional. I'll just need to make changes to the cryogen repository as well and then look into documentation changes. |
niamu
changed the title
|
Finally found some time to test this out and fixed up the remaining bugs with it. I've also created cryogen-project/cryogen#181 which only leaves documentation changes which I will get to shortly. |
|
Documentation changes are here: cryogen-project/cryogen-docs#22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full disclosure; I haven't tested this yet. I'll get around to testing it in the next day or so.
This work represents most of the solution I outlined here: cryogen-project/cryogen#166 (comment)
Once this branch is confirmed completed and ready to be merged, there are still
clean-urls?references in cryogen-project/cryogen that also need to be addressed as well as documentation updates that will be necessary.