fixed build vite-plugin on windows (fix #473)

[GoodSimonVM]

It's build now, but pnpm run test has a lot of errors. I think it's because path.posix is used in tests, but I don't know much about testing.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 115a1a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
vite-plugin-docs	⬜️ Ignored (Inspect)		Aug 19, 2022 at 0:36AM (UTC)

[jacksteamdev]

@GoodSimonVM Thanks for this PR! I really want to support development on Windows and this looks like the right direction.

Rollup/Vite use posix internally, and in a previous version of CRXJS, we needed to use posix to support certain Rollup/Vite features.

The CI tests are passing on Mac/Linux, but this could be a breaking change for certain Vite settings, so I'm nervous about merging this without more thorough testing.

I will set aside some time to test this in a real project, but my open-source time is limited right now, so it may take a few weeks.

[jacebenson]

Is there anyway I can help with this?

[linonetwo]

I encounter this, how to workaround?

[linonetwo]

Manually replace import { posix } from 'path';

with

import {
  basename,
  dirname,
  extname,
  delimiter,
  format,
  isAbsolute,
  join,
  normalize,
  parse,
  relative,
  resolve,
  toNamespacedPath,
  sep
} from 'path';