Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types #113

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Typescript types #113

merged 5 commits into from
Apr 9, 2022

Conversation

notourist
Copy link
Contributor

@notourist notourist commented Apr 27, 2021

I added and polished the types from @ChadJPetersen (https://gist.github.com/ChadJPetersen/2e2587bbd753c6a384c02519183e2031). If you don't want to merge #112, 5bc7e31 needs to be reverted.

This also fixes #80

@jsdtaylor
Copy link

@usr14 can you use params?: unknown instead of any?

@jbrownson
Copy link

I'm looking at using react-graph-vis in a Typescript project and it would be great to have types, is this just being held up by the change requested by @jsdtaylor?

@crubier crubier merged commit 463323a into crubier:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use react-graph-vis with typescript
4 participants