Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#291 Fix Select(Field) not working with 0 value #292

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

fbeceic
Copy link
Collaborator

@fbeceic fbeceic commented Dec 17, 2024

Basic information

  • Tiller version: 1.15.1
  • Module: selectors

Description

Summary

Fixed Select(Field)'s broken functionality when 0 is provided as a value (Select and SelectField) or when 0 is the return value of getOptionValue prop (SelectField).

Related issue

#291

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's Prettier code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added a story to cover my changes
  • All new and existing story tests pass

@fbeceic fbeceic requested a review from jtomic-croz December 17, 2024 11:44
@fbeceic fbeceic self-assigned this Dec 17, 2024
@jtomic-croz jtomic-croz merged commit 6455ef3 into master Dec 17, 2024
@fbeceic fbeceic deleted the bugfix/291 branch December 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants