Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#236 DataTable - add retainDefaultSortBy prop for preserving default sorting #259

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

fbeceic
Copy link
Collaborator

@fbeceic fbeceic commented Jun 4, 2024

Basic information

  • Tiller version: 1.13.0
  • Module: data-display

Description

Summary

Added possibility of retaining initial sort defined by defaultSortBy prop when sorting DataTable's columns via header arrows.

Details

New prop has been added for retaining initial sort configuration:

  • retainDefaultSortBy

Related issue

#236

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's Prettier code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added a story to cover my changes
  • All new and existing story tests pass

@fbeceic fbeceic requested a review from jtomic-croz June 4, 2024 13:45
@fbeceic fbeceic self-assigned this Jun 4, 2024
@fbeceic fbeceic changed the title #236 DataTable - add retainDefaultSortBy prop for preserving defaul… #236 DataTable - add retainDefaultSortBy prop for preserving default sorting Jun 4, 2024
@jtomic-croz jtomic-croz merged commit ceef061 into master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants