Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#252 DataTable - add possibility of conditionally rendering the expander #258

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

fbeceic
Copy link
Collaborator

@fbeceic fbeceic commented Jun 3, 2024

Basic information

  • Tiller version: 1.13.0
  • Module: data-display

Description

Summary

Added possibility of conditionally rendering the expander column and its expanded content on DataTable component based on the newly-added predicate prop to the DataTable.Expander subcomponent.

Details

New props have been added for enabling conditional expander rendering:

  • predicate: defines whether a given row should be expandable
  • predicateFallback: the component rendered when the predicate prop is not satisfied
  • className: optional class name for the expander column

Related issue

#252

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's Prettier code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added a story to cover my changes
  • All new and existing story tests pass

@fbeceic fbeceic requested a review from jtomic-croz June 3, 2024 14:56
@fbeceic fbeceic self-assigned this Jun 3, 2024
@jtomic-croz jtomic-croz merged commit d7484e6 into master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants