Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#196 Fix clear button accidentally submitting a form on Select #200

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

fbeceic
Copy link
Collaborator

@fbeceic fbeceic commented Feb 8, 2024

Basic information

  • Tiller version: 1.8.0
  • Module: form-elements

Description

Fixed unintentional form submission when clicking a clear button on Select component.

Related issue

Closes #196

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's Prettier code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added a story to cover my changes
  • All new and existing story tests pass

@fbeceic fbeceic added the bug Something isn't working label Feb 8, 2024
@fbeceic fbeceic requested review from ivam5 and jtomic-croz February 8, 2024 15:56
@fbeceic fbeceic self-assigned this Feb 8, 2024
@fbeceic fbeceic changed the title Fix clear button accidentally submitting a form on Select #196 Fix clear button accidentally submitting a form on Select Feb 8, 2024
@jtomic-croz jtomic-croz merged commit 57375bd into master Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select component's clear button submits form
2 participants