Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable sorting always present #239

Closed
fbeceic opened this issue Apr 3, 2024 · 0 comments
Closed

DataTable sorting always present #239

fbeceic opened this issue Apr 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@fbeceic
Copy link
Collaborator

fbeceic commented Apr 3, 2024

Basic information

  • Tiller version: 1.11.0
  • Module: data-display

Bug description

DataTable's sorting arrows next to column names are always shown, even if the specified column has the canSort prop set to false.

Cursor pointer is not shown (regular cursor is on hover), but the sorting functionality is still present.

Additionally, sorting on the selector column (if <DataTable.Selector /> is defined) is present, which makes no sense since this column shouldn't be sortable.

Steps to reproduce

  • render DataTable
  • click on a certain column header
  • the column sorting functionality is present in all use cases, regardless of the canSort prop

Expected behavior

Columns with canSort set to false shouldn't have sorting functionality when clicking on the column header.
Selector columns shouldn't be sortable.

Actual behavior

Columns with canSort set to false have sorting functionality when clicking on the column header.
Selector columns are always sortable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants