Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove if log check in one instance #3300

Merged

Conversation

LaurenceJJones
Copy link
Contributor

We check the log level if we are about to send resource intensive items to the logger, in this case it is not needed.

@LaurenceJJones
Copy link
Contributor Author

/kind fix
/area agent

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (9d6ccb0) to head (ebf7c8f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3300      +/-   ##
==========================================
- Coverage   58.23%   58.22%   -0.01%     
==========================================
  Files         335      335              
  Lines       37428    37427       -1     
==========================================
- Hits        21797    21793       -4     
- Misses      13733    13735       +2     
- Partials     1898     1899       +1     
Flag Coverage Δ
bats 41.30% <100.00%> (+<0.01%) ⬆️
unit-linux 33.99% <100.00%> (-0.02%) ⬇️
unit-windows 29.26% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones merged commit 3ead746 into crowdsecurity:master Oct 28, 2024
17 checks passed
@LaurenceJJones LaurenceJJones deleted the remove_log_if_check branch October 28, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants