-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bouncer registration via secrets #3275
base: master
Are you sure you want to change the base?
Conversation
@victorpsantos: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@victorpsantos: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind fix |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3275 +/- ##
=======================================
Coverage 39.21% 39.21%
=======================================
Files 480 480
Lines 62075 62075
=======================================
+ Hits 24341 24345 +4
+ Misses 35091 35087 -4
Partials 2643 2643
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Previously, the code was using
awk -F "/" '{printf $NF}' | cut -d_ -f2-
to extract the bouncer name from the secret file path. However, this was causing an issue where the bouncer name was being extracted incorrectly.The fix is to change
cut -d_ -f2-
tocut -d_ -f3-
, so that the bouncer name is extracted correctly.