Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact / split APIServer.Run() method #3215

Merged
merged 1 commit into from
Sep 12, 2024
Merged

refact / split APIServer.Run() method #3215

merged 1 commit into from
Sep 12, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 5, 2024

for readability

@mmetc mmetc added this to the 1.6.4 milestone Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 32.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 51.22%. Comparing base (57539f6) to head (74effcb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/apiserver.go 32.00% 31 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3215      +/-   ##
==========================================
- Coverage   51.25%   51.22%   -0.04%     
==========================================
  Files         340      340              
  Lines       38771    38780       +9     
==========================================
- Hits        19873    19865       -8     
- Misses      16942    16954      +12     
- Partials     1956     1961       +5     
Flag Coverage Δ
bats 40.72% <38.09%> (-0.02%) ⬇️
unit-linux 34.66% <0.00%> (+0.01%) ⬆️
unit-windows 28.57% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested a review from blotus September 5, 2024 13:22
@mmetc mmetc merged commit d5c587c into master Sep 12, 2024
17 checks passed
@mmetc mmetc deleted the refact-apiserver-run branch September 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants