Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency on docker #3175

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

update dependency on docker #3175

wants to merge 5 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 9, 2024

since docker doesn't have a go.mod, the opentelemetry dependencies in go.sum must be updated by hand according to the vendor.mod file of the related docker release

ex. https://github.com/docker/cli/blob/v27.1.1/vendor.mod

Copy link

github-actions bot commented Aug 9, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as draft August 9, 2024 11:16
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.31%. Comparing base (2ab93f7) to head (f1cf22b).

Files with missing lines Patch % Lines
pkg/metabase/container.go 0.00% 5 Missing ⚠️
pkg/acquisition/modules/docker/docker.go 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2ab93f7) and HEAD (f1cf22b). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2ab93f7) HEAD (f1cf22b)
unit-windows 1 0
unit-linux 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3175       +/-   ##
===========================================
- Coverage   58.43%   41.31%   -17.13%     
===========================================
  Files         351      333       -18     
  Lines       37827    36446     -1381     
===========================================
- Hits        22106    15056     -7050     
- Misses      13817    19908     +6091     
+ Partials     1904     1482      -422     
Flag Coverage Δ
bats 41.31% <0.00%> (+0.04%) ⬆️
unit-linux ?
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review August 9, 2024 12:31
@mmetc mmetc marked this pull request as draft August 9, 2024 12:42
@mmetc mmetc modified the milestones: 1.6.4, 1.6.5 Oct 30, 2024
@mmetc mmetc force-pushed the dep-docker branch 2 times, most recently from 6a25b84 to e402f12 Compare November 4, 2024 12:49
since docker doesn't have a go.mod, the opentelemetry dependencies
in go.sum must be updated by hand according to the vendor.mod file
of the related docker release

ex. https://github.com/docker/cli/blob/v27.1.1/vendor.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant