Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop axios #88

Merged
merged 3 commits into from
Sep 11, 2024
Merged

feat: drop axios #88

merged 3 commits into from
Sep 11, 2024

Conversation

yevheniyJ
Copy link
Collaborator

No description provided.

@yevheniyJ yevheniyJ linked an issue Sep 9, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (655fb32) to head (0d52409).

Files with missing lines Patch % Lines
src/index.ts 50.00% 0 Missing and 1 partial ⚠️
src/internal/http/fetch.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   79.68%   79.37%   -0.30%     
==========================================
  Files           3        3              
  Lines         123      126       +3     
  Branches       24       26       +2     
==========================================
+ Hits           98      100       +2     
  Misses         11       11              
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar
Copy link
Member

This is probably also not relevant anymore - https://crowdin.github.io/ota-client-js/configuration#axios-error

@yevheniyJ yevheniyJ marked this pull request as ready for review September 10, 2024 15:16
@andrii-bodnar andrii-bodnar merged commit cf130aa into main Sep 11, 2024
14 checks passed
@andrii-bodnar andrii-bodnar deleted the axios-removal branch September 11, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios error and vulnerability
3 participants